On Thu, 28 Jul 2016 16:07:16 -0700 Andrey Smirnov <andrew.smir...@gmail.com> wrote:
> Factor out a small bit of common code in machine_restart(), > machine_power_off() and machine_halt(). > > Signed-off-by: Andrey Smirnov <andrew.smir...@gmail.com> > --- > > No changes compared to v1. > > arch/powerpc/kernel/setup-common.c | 23 ++++++++++++++--------- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/arch/powerpc/kernel/setup-common.c > b/arch/powerpc/kernel/setup-common.c index 714b4ba..5cd3283 100644 > --- a/arch/powerpc/kernel/setup-common.c > +++ b/arch/powerpc/kernel/setup-common.c > @@ -130,15 +130,22 @@ void machine_shutdown(void) > ppc_md.machine_shutdown(); > } > > +static void machine_hang(void) > +{ > + pr_emerg("System Halted, OK to turn off power\n"); > + local_irq_disable(); > + while (1) > + ; > +} What's the intended semantics of this function? A default power off handler when the platform supplies none? Would ppc_power_off() be a good name? Should the smp_send_stop() call be moved here? It seems like a reasonable cleanup though. Thanks, Nick