On Sun, Jul 31, 2016 at 11:28:34PM -0400, Valdis Kletnieks wrote:
> When building with W=1, we get these warnings:
>
> drivers/ata/libata-scsi.c: In function 'ata_mselect_caching':
> drivers/ata/libata-scsi.c:3637:28: warning: suggest parentheses around
> comparison in operand of '&' [-Wparentheses]
> if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
> ~~~~~^~~~~~~~~
> drivers/ata/libata-scsi.c: In function 'ata_mselect_control':
> drivers/ata/libata-scsi.c:3702:28: warning: suggest parentheses around
> comparison in operand of '&' [-Wparentheses]
> if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
> ~~~~~^~~~~~~~~
>
> So give them the extra () and make things a bit clearer for both the
> compiler and programmer...
>
> Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu>
The offending commit got already reverted.
Thanks!
--
tejun
