I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/ide/cs5536.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/cs5536.c b/drivers/ide/cs5536.c index de9185d..5a9f702 100644 --- a/drivers/ide/cs5536.c +++ b/drivers/ide/cs5536.c @@ -302,5 +302,5 @@ MODULE_DESCRIPTION("low-level driver for the CS5536 IDE controller"); MODULE_LICENSE("GPL"); MODULE_DEVICE_TABLE(pci, cs5536_pci_tbl); -module_param_named(msr, use_msr, int, 0644); +module_param_named(msr, use_msr, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(msr, "Force using MSR to configure IDE function (Default: 0)"); -- 2.9.2
