On Tue, 2016-08-02 at 19:53 +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access > permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using macro can improve the robustness and readability of > the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng....@intel.com> > Signed-off-by: Baole Ni <baolex...@intel.com> > --- > > static int timeout = 5000; /* in msec ( 5 sec ) */ > -module_param(timeout, int, 0644); > +module_param(timeout, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
To me, 644 is more 'readable', and as for robustness, the meaning of 644 will never change. -Geoff
