On Mon, 2016-08-08 at 18:22 +0800, Jia He wrote: > buff[] will be assigned later, so memset is not necessary. > > Signed-off-by: Jia He <[email protected]> > Cc: "David S. Miller" <[email protected]> > Cc: Alexey Kuznetsov <[email protected]> > Cc: James Morris <[email protected]> > Cc: Hideaki YOSHIFUJI <[email protected]> > Cc: Patrick McHardy <[email protected]> > --- > net/ipv6/addrconf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index ab3e796..43fa8d0 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -4967,7 +4967,6 @@ static inline void __snmp6_fill_stats64(u64 *stats, > void __percpu *mib, > > BUG_ON(pad < 0); > > - memset(buff, 0, sizeof(buff)); > buff[0] = IPSTATS_MIB_MAX; > > for_each_possible_cpu(c) {
This is completely buggy, since we performs additions, not assignments : buff[i] += snmp_get_cpu_field64(mib, c, i, syncpoff); Please do not send untested patches.
