On Sunday 11 February 2007 12:13, Eric W. Biederman wrote: > Andi Kleen <[EMAIL PROTECTED]> writes: > > > From: Ingo Molnar <[EMAIL PROTECTED]> > > > > Default to physical mode on hotplug CPU kernels. Furher simplify and clean > > up > > the APIC initialization code. > > Where is the code that the subject describes?
True, that seems to be missing. I agree that the patch seems to consist mostly of renaming doesn't make it any easier to read. And it's worrying that it doesn't handle the hotplug case at all. > I have two problems here. > > - I don't see anything handling the hotplug case, and forcing us to > physical mode. > - Ingo's other patch asserts that hotplug should be made to handle > logical deliver mode. > > With logical deliver mode the experimental evidence is that the > destination cpu is a hint, What experimental evidence did you have? But I'm tempted to drop this unless the hotplug mystery can be cleared up. There was past information that logical is unsafe for hotplug. Ingo? Suresh? -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
