From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 21 Aug 2016 15:30:11 +0200

The script "checkpatch.pl" can point out that assignments should usually
not be performed within condition checks.
Thus move the assignments for two local variables to separate statements.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/usb/misc/iowarrior.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c
index 132c8cf..78b5d65 100644
--- a/drivers/usb/misc/iowarrior.c
+++ b/drivers/usb/misc/iowarrior.c
@@ -292,7 +292,8 @@ static ssize_t iowarrior_read(struct file *file, char 
__user *buffer,
        /* repeat until no buffer overrun in callback handler occur */
        do {
                atomic_set(&dev->overflow_flag, 0);
-               if ((read_idx = read_index(dev)) == -1) {
+               read_idx = read_index(dev);
+               if (read_idx == -1) {
                        /* queue empty */
                        if (file->f_flags & O_NONBLOCK)
                                return -EAGAIN;
@@ -616,7 +617,8 @@ static int iowarrior_open(struct inode *inode, struct file 
*file)
        }
 
        /* setup interrupt handler for receiving values */
-       if ((retval = usb_submit_urb(dev->int_in_urb, GFP_KERNEL)) < 0) {
+       retval = usb_submit_urb(dev->int_in_urb, GFP_KERNEL);
+       if (retval < 0) {
                dev_err(&interface->dev, "Error %d while submitting URB\n", 
retval);
                retval = -EFAULT;
                goto out;
-- 
2.9.3

Reply via email to