On Thu, 8 Sep 2016, Fenghua Yu wrote: > From: Fenghua Yu <fenghua...@intel.com> > > We use ci_cpu_cacheinfo in CAT. Export this function for CAT to reuse.
So ci_cpu_cacheinfo is a function? AFAICT it's a struct. > +#define ci_cacheinfo(cpu) (&per_cpu(ci_cpu_cacheinfo, cpu)) Why a define and not an inline? &per_cpu should be per_cpu_ptr .... And a define is not a function either and certainly that whole thing has nothing to do with an export. Furthermore $subject talks about some functions. I still have to see one. It's an art to get a onliner patch screwed up in more than one way so badly. No bisquit! tglx