This patch enhances the error path in recover_orphan_inode.

Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org>
---
 fs/f2fs/checkpoint.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index b80dd37..36073a1 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -531,8 +531,9 @@ void remove_orphan_inode(struct f2fs_sb_info *sbi, nid_t 
ino)
 static int recover_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino)
 {
        struct inode *inode;
+       struct node_info ni;
 
-       inode = f2fs_iget(sbi->sb, ino);
+       inode = f2fs_iget_retry(sbi->sb, ino);
        if (IS_ERR(inode)) {
                /*
                 * there should be a bug that we can't find the entry
@@ -546,6 +547,23 @@ static int recover_orphan_inode(struct f2fs_sb_info *sbi, 
nid_t ino)
 
        /* truncate all the data during iput */
        iput(inode);
+
+       get_node_info(sbi, ino, &ni);
+
+       /* ENOMEM was fully retried in f2fs_evict_inode. */
+       if (ni.blk_addr != NULL_ADDR) {
+               int err = acquire_orphan_inode(sbi);
+
+               if (err) {
+                       set_sbi_flag(sbi, SBI_NEED_FSCK);
+                       f2fs_msg(sbi->sb, KERN_WARNING,
+                               "%s: orphan failed (ino=%x), run fsck to fix.",
+                                       __func__, ino);
+                       return err;
+               }
+               __add_ino_entry(sbi, ino, ORPHAN_INO);
+               alloc_nid_done(sbi, ino);
+       }
        return 0;
 }
 
-- 
2.8.3

Reply via email to