Hi Arnd,
Looks good to me.
Acked-by: Chanwoo Choi <cw00.c...@samsung.com>
Best Regards,
Chanwoo Choi
2016-09-16 0:44 GMT+09:00 Arnd Bergmann <a...@arndb.de>:
> The newly added ARM_RK3399_DMC_DEVFREQ driver requires the
> DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through
> a 'select' statement, and that in turn has a dependency on
> PM_DEVFREQ_EVENT, which may be disabled here:
>
> warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which
> has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT &&
> ARCH_ROCKCHIP)
>
> We probably want a 'depends on' here, but other drivers use 'select'
> too, so for consistency I'm doing the same.
>
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399
> dmc")
> ---
> drivers/devfreq/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 93b6ada06676..41254e702f1e 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -105,6 +105,7 @@ config ARM_RK3399_DMC_DEVFREQ
> depends on ARCH_ROCKCHIP
> select DEVFREQ_EVENT_ROCKCHIP_DFI
> select DEVFREQ_GOV_SIMPLE_ONDEMAND
> + select PM_DEVFREQ_EVENT
> select PM_OPP
> help
> This adds the DEVFREQ driver for the RK3399 DMC(Dynamic Memory
> Controller).
> --
> 2.9.0
>
