On Mon, Feb 19, 2007 at 07:07:46PM +0200, Artem Bityutskiy wrote: > > And when you create that many interfaces, it adds inertia to changing > > the interfaces later on, because it's sometimes not clear how many > > users of the interface there really are. My general rule of thumb is > > that if an interface only has one user, then it may be a good idea to > > combine it with the user of that interface, and then make the > > functions involved be a static, so that it becomes clear the only user > > of that functoin is within that one file. You can take this too far, > > and to extremes it doesn't work all that well, but the UBI layer has > > gone waaaaaay off the deep end in terms of functional decomposition. > > Well... I do not want any flame on this topic. It is about taste, > trade-offs, compromises. It is difficult to provide _objective_ and > killing arguments here. But I will think on this, point taken, thanks.
Codingstyle is and always will be about tastes, but it usually helps a lot if you try to understand and follow the style of the project you want to contribute to :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/