* Jeroen Hofstee <jhofs...@victronenergy.com> [161021 02:31]: > Aaah, lets wait a sec. I just saw there is another user of this function, > so above is simply not true.... > > if (of_machine_is_compatible("ti,dra7")) > return davinci_emac_3517_get_macid(dev, 0x514, slave, mac_addr);
Oh OK, then this will produce duplicate macs. > So let me check if I don't break that one..... or better, let me send a v2, > which > changes the caller to pass slave as 0 here? > > if (of_device_is_compatible(dev->of_node, "ti,am3517-emac")) > return davinci_emac_3517_get_macid(dev, 0x110, slave, mac_addr); > Yeah that sounds good to me. Regards, Tony