Commit-ID: 18f278d2dd68fdccf8810e78d10d6b75a6f2f67a Gitweb: http://git.kernel.org/tip/18f278d2dd68fdccf8810e78d10d6b75a6f2f67a Author: Jiri Olsa <jo...@kernel.org> AuthorDate: Tue, 11 Oct 2016 13:39:47 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitDate: Fri, 21 Oct 2016 10:32:01 -0300
perf c2c report: Add --no-source option Add a possibility to disable source line column with new --no-source option. It source line data could take lot of time to retrieve, so it could be a performance burden for big data. Signed-off-by: Jiri Olsa <jo...@kernel.org> Cc: Andi Kleen <a...@firstfloor.org> Cc: David Ahern <dsah...@gmail.com> Cc: Don Zickus <dzic...@redhat.com> Cc: Joe Mario <jma...@redhat.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Link: http://lkml.kernel.org/n/tip-8p6s2727fq8nbsm3it5gi...@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com> --- tools/perf/Documentation/perf-c2c.txt | 3 +++ tools/perf/builtin-c2c.c | 13 ++++++++----- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/tools/perf/Documentation/perf-c2c.txt b/tools/perf/Documentation/perf-c2c.txt index ba2f4de..33ed456 100644 --- a/tools/perf/Documentation/perf-c2c.txt +++ b/tools/perf/Documentation/perf-c2c.txt @@ -94,6 +94,9 @@ REPORT OPTIONS --full-symbols:: Display full length of symbols. +--no-source:: + Do not display Source:Line column. + C2C RECORD ---------- The perf c2c record command setup options related to HITM cacheline analysis diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c index 32c9e62..7eb418d 100644 --- a/tools/perf/builtin-c2c.c +++ b/tools/perf/builtin-c2c.c @@ -2404,7 +2404,7 @@ static int setup_display(const char *str) for (__tok = strtok_r(__buf, __sep, &__tmp); __tok; \ __tok = strtok_r(NULL, __sep, &__tmp)) -static int build_cl_output(char *cl_sort) +static int build_cl_output(char *cl_sort, bool no_source) { char *tok, *tmp, *buf = strdup(cl_sort); bool add_pid = false; @@ -2426,7 +2426,7 @@ static int build_cl_output(char *cl_sort) add_iaddr = true; add_sym = true; add_dso = true; - add_src = true; + add_src = no_source ? false : true; } else if (!strcmp(tok, "dso")) { add_dso = true; } else if (strcmp(tok, "offset")) { @@ -2462,14 +2462,14 @@ static int build_cl_output(char *cl_sort) return 0; } -static int setup_coalesce(const char *coalesce) +static int setup_coalesce(const char *coalesce, bool no_source) { const char *c = coalesce ?: coalesce_default; if (asprintf(&c2c.cl_sort, "offset,%s", c) < 0) return -ENOMEM; - if (build_cl_output(c2c.cl_sort)) + if (build_cl_output(c2c.cl_sort, no_source)) return -1; if (asprintf(&c2c.cl_resort, "offset,%s", @@ -2494,6 +2494,7 @@ static int perf_c2c__report(int argc, const char **argv) char callchain_default_opt[] = CALLCHAIN_DEFAULT_OPT; const char *display = NULL; const char *coalesce = NULL; + bool no_source = false; const struct option c2c_options[] = { OPT_STRING('k', "vmlinux", &symbol_conf.vmlinux_name, "file", "vmlinux pathname"), @@ -2510,6 +2511,8 @@ static int perf_c2c__report(int argc, const char **argv) "Use the stdio interface"), OPT_BOOLEAN(0, "full-symbols", &c2c.symbol_full, "Display full length of symbols"), + OPT_BOOLEAN(0, "no-source", &no_source, + "Do not display Source Line column"), OPT_CALLBACK_DEFAULT('g', "call-graph", &callchain_param, "print_type,threshold[,print_limit],order,sort_key[,branch],value", callchain_help, &parse_callchain_opt, @@ -2545,7 +2548,7 @@ static int perf_c2c__report(int argc, const char **argv) if (err) goto out; - err = setup_coalesce(coalesce); + err = setup_coalesce(coalesce, no_source); if (err) { pr_debug("Failed to initialize hists\n"); goto out;
