On Mon, Oct 24, 2016 at 10:11:27AM -0700, Randy Dunlap wrote: > On 10/23/16 22:41, Vadim Pasternak wrote: > > > > > >> -----Original Message----- > >> From: Randy Dunlap [mailto:rdun...@infradead.org] > >> Sent: Sunday, October 23, 2016 7:57 PM > >> To: Vadim Pasternak <vad...@mellanox.com>; dvh...@infradead.org; > >> fengguang...@intel.com > >> Cc: da...@davemloft.net; ge...@linux-m68k.org; akpm@linux- > >> foundation.org; kv...@codeaurora.org; gre...@linuxfoundation.org; > >> mche...@kernel.org; li...@roeck-us.net; linux-kernel@vger.kernel.org; > >> platform-driver-...@vger.kernel.org; j...@resnulli.us; > >> andriy.shevche...@linux.intel.com > >> Subject: Re: [patch v1] drivers/platform/x86: select hwmon for Mellanox > >> hotplug driver in Kconfig > >> > >> On 10/23/16 05:45, vad...@mellanox.com wrote: > >>> From: Vadim Pasternak <vad...@mellanox.com> > >>> > >>> Add select HWMON for mlxcpld-hotplug driver config, since it requires > >>> hwmon APIs. > >>> > >>> Signed-off-by: Vadim Pasternak <vad...@mellanox.com> > >>> --- > >>> drivers/platform/x86/Kconfig | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/drivers/platform/x86/Kconfig > >>> b/drivers/platform/x86/Kconfig index 65d9b04..1853769 100644 > >>> --- a/drivers/platform/x86/Kconfig > >>> +++ b/drivers/platform/x86/Kconfig > >>> @@ -1032,6 +1032,7 @@ config MLX_CPLD_PLATFORM > >>> tristate "Mellanox platform hotplug driver support" > >>> default n > >>> depends on MLX_PLATFORM > >>> + select HWMON > >>> select I2C > >>> ---help--- > >>> This driver handles hot-plug events for the power suppliers, power > >>> > >> > >> Hi, > >> did you test this? I would expect it to cause a kconfig warning, > >> something about > >> HWMON having a dependency on HAS_IOMEM. > > > > Hi Randy, > > > > Yes, > > I built tree with this fix with the attached .config file. > > Didn't see kconfig warnings. > > I can have a look again. > > No need. lib/Kconfig handles it: > > config HAS_IOMEM > bool > depends on !NO_IOMEM > select GENERIC_IO > default y > > > thanks. > -- > ~Randy >
Thanks for the review all. I've merged this with the original commit, now in next. -- Darren Hart Intel Open Source Technology Center
