Always bio_add_page() is the standard and preferred way to
do the task.

Reviewed-by: Christoph Hellwig <h...@lst.de>
Signed-off-by: Ming Lei <tom.leim...@gmail.com>
---
 fs/logfs/dev_bdev.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c
index 2bf53b0ffe83..696dcdd65fdd 100644
--- a/fs/logfs/dev_bdev.c
+++ b/fs/logfs/dev_bdev.c
@@ -20,15 +20,12 @@ static int sync_request(struct page *page, struct 
block_device *bdev, int op)
        struct bio_vec bio_vec;
 
        bio_init_with_vec_table(&bio, &bio_vec, 1);
-       bio_vec.bv_page = page;
-       bio_vec.bv_len = PAGE_SIZE;
-       bio_vec.bv_offset = 0;
-       bio.bi_vcnt = 1;
        bio.bi_bdev = bdev;
        bio.bi_iter.bi_sector = page->index * (PAGE_SIZE >> 9);
-       bio.bi_iter.bi_size = PAGE_SIZE;
        bio_set_op_attrs(&bio, op, 0);
 
+       bio_add_page(&bio, page, PAGE_SIZE, 0);
+
        return submit_bio_wait(&bio);
 }
 
-- 
2.7.4

Reply via email to