>>On Tue, 1 Nov 2016, Grzegorz Andrejczuk wrote: >> >> +/* Intel Xeon Phi x200 ring 3 MONITOR/MWAIT */ > >Oh well. I asked you to make that whole PHI thing go away. > >This is a feature which has nothing to do with PHI. It just happens to be >implemented on PHI. The FEATURES_ENABLES MSR is not at all PHI specific. > >It's all about a feature which enables ring 3 mwait/monitor.
This bit enables ring 3 MONITOR/MWAIT only on Xeon Phi. It is reserved for other architectures. I think this will be confusing when I remove PHI. >> +#define MSR_MISC_FEATURE_ENABLES 0x00000140 >> +#define MSR_MISC_FEATURE_ENABLES_PHIR3MWAIT_BIT 1 >> +#define MSR_MISC_FEATURE_ENABLES_PHIR3MWAIT (1ULL << >> MSR_MISC_FEATURE_ENABLES_PHIR3MWAIT_BIT) >> + > >You really try hard to get your crap behind me. Stop sending out half baken >shit every other day without addressing my review comments. > >Your trust level approaches negative space. > >Thanks, > > tglx Regards, Grzegorz
