On 11/11/16 14:22, Lars-Peter Clausen wrote: > On 11/11/2016 07:34 AM, Eva Rachel Retuya wrote: >> Move the ad7606 driver from staging/iio/adc to iio/adc. Also, update the >> corresponding Makefile and Kconfig associated with the change. > > This is obviously OK, but when you generate a patch that moves files use > `git format-patch -M ...`. This will generate a more compact patch. > I tend to make an exception for staging graduation patches. The mere posting of the whole driver by not using the move detection makes for really easy review of whether we have forgotten something else that needs cleanup before the graduation.
Most of the time -M is much more sensible! Jonathan
