On Fri, Nov 11, 2016 at 08:50:17AM +0000, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <[email protected]> > > Scatterlist entries have an unsigned int for the offset so > correct the sg_alloc_table_from_pages function accordingly. > > Since these are offsets withing a page, unsigned int is > wide enough. > > Also converts callers which were using unsigned long locally > with the lower_32_bits annotation to make it explicitly > clear what is happening. > > v2: Use offset_in_page. (Chris Wilson) > > Signed-off-by: Tvrtko Ursulin <[email protected]> > Cc: Masahiro Yamada <[email protected]> > Cc: Pawel Osciak <[email protected]> > Cc: Marek Szyprowski <[email protected]> > Cc: Kyungmin Park <[email protected]> > Cc: Tomasz Stanislawski <[email protected]> > Cc: Matt Porter <[email protected]> > Cc: Alexandre Bounine <[email protected]> > Cc: [email protected] > Cc: [email protected] > Acked-by: Marek Szyprowski <[email protected]> (v1)
If there were kerneldoc, it would nicely explain that having an offset larger then a page is silly when passing in array of pages. Changes elsewhere look ok (personally I'd be happy with just offset_in_page(), 4GiB superpages are somebody else's problem :) Reviewed-by: Chris Wilson <[email protected]> -Chris -- Chris Wilson, Intel Open Source Technology Centre
