Lukas Wunner <lu...@wunner.de> wrote: > It just occurred to me that the boot_params struct is populated in > make_boot_params(), perhaps it makes sense to move this line there. > Otherwise LGTM.
Ummm... Looking at arch/x86/boot/compressed/head_64.S, make_boot_params() is only called if the stub is entered through efi_pe_entry, not if entered through efi64_stub_entry, whereas efi_main() is called in both cases. I think entry through efi32_stub_entry may also skip make_boot_params(). The comment on make_boot_params() suggests that this function is only used if whoever booted the kernel didn't supply it. David
