On Wed, Nov 23, 2016 at 12:23:04AM +0000, David Howells wrote: > + /* See if a user has put shim into insecure mode. If so, and if the > + * variable doesn't have the runtime attribute set, we might as well > + * honor that. > + */ > + size = sizeof(moksbstate); > + status = get_efi_var(shim_MokSBState_name, &shim_guid, > + &attr, &size, &moksbstate); > + > + /* If it fails, we don't care why. Default to secure */ > + if (status != EFI_SUCCESS) > + return 1;
I was going to suggest branching to out_efi_err, but I see that wouldn't work when EFI_NOT_FOUND was returned. It might be worth noting explicitly that we can't use that, so as to avoid 'obvious' cleanup in future. Thanks, Mark.
