On Sun 27-11-16 00:13:35, Sebastian Andrzej Siewior wrote: > Both functions are called with protection against cpu hotplug already so > *_online_cpus() could be dropped. > > Cc: Andrew Morton <[email protected]> > Cc: Vlastimil Babka <[email protected]> > Cc: Mel Gorman <[email protected]> > Cc: Johannes Weiner <[email protected]> > Cc: [email protected] > Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Acked-by: Michal Hocko <[email protected]> > --- > mm/vmstat.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 604f26a4f696..0b63ffb5c407 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1722,24 +1722,19 @@ static void __init init_cpu_node_state(void) > { > int cpu; > > - get_online_cpus(); > for_each_online_cpu(cpu) > node_set_state(cpu_to_node(cpu), N_CPU); > - put_online_cpus(); > } > > static void vmstat_cpu_dead(int node) > { > int cpu; > > - get_online_cpus(); > for_each_online_cpu(cpu) > if (cpu_to_node(cpu) == node) > - goto end; > + return; > > node_clear_state(node, N_CPU); > -end: > - put_online_cpus(); > } > > /* > -- > 2.10.2 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to [email protected]. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"[email protected]";> [email protected] </a> -- Michal Hocko SUSE Labs
