On 2016/12/9 22:55, Ard Biesheuvel wrote: > On 9 December 2016 at 06:54, Kefeng Wang <[email protected]> wrote: >> Let's keep consistent when print dmi_ids_string between SMBIOS 2.x >> and SMBIOS 3.x, and always show the system identification string, >> like Vendor, Product/Board name and BIOS infos. >> > > Are you saying the printk(KERN_DEBUG) was inconsistent with the > pr_debug() before?
Yes, found it when check the boot dmesg on qemu, there is no print using pr_debug with defconfig on ARM64( smbios3 present), but could shown with printk(KERN_DEBUG. > > >> Signed-off-by: Kefeng Wang <[email protected]> >> --- >> drivers/firmware/dmi_scan.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c >> index 88bebe1..54be60e 100644 >> --- a/drivers/firmware/dmi_scan.c >> +++ b/drivers/firmware/dmi_scan.c >> @@ -560,7 +560,7 @@ static int __init dmi_present(const u8 *buf) >> dmi_ver >> 16, (dmi_ver >> 8) & >> 0xFF); >> } >> dmi_format_ids(dmi_ids_string, >> sizeof(dmi_ids_string)); >> - printk(KERN_DEBUG "DMI: %s\n", dmi_ids_string); >> + pr_info("DMI: %s\n", dmi_ids_string); >> return 0; >> } >> } >> @@ -588,7 +588,7 @@ static int __init dmi_smbios3_present(const u8 *buf) >> dmi_ver >> 16, (dmi_ver >> 8) & 0xFF, >> dmi_ver & 0xFF); >> dmi_format_ids(dmi_ids_string, >> sizeof(dmi_ids_string)); >> - pr_debug("DMI: %s\n", dmi_ids_string); >> + pr_info("DMI: %s\n", dmi_ids_string); >> return 0; >> } >> } >> -- >> 1.7.12.4 >> > > . >
