On 12/13/2016 04:04 AM, Bart Van Assche wrote:
> On 12/08/2016 09:13 PM, Jens Axboe wrote:
>> +static int dd_init_queue(struct request_queue *q, struct elevator_type *e)
>> +{
>> + struct deadline_data *dd;
>> + struct elevator_queue *eq;
>> +
>> + eq = elevator_alloc(q, e);
>> + if (!eq)
>> + return -ENOMEM;
>> +
>> + dd = kzalloc_node(sizeof(*dd), GFP_KERNEL, q->node);
>> + if (!dd) {
>> + kobject_put(&eq->kobj);
>> + return -ENOMEM;
>> + }
>> + eq->elevator_data = dd;
>> +
>> + dd->tags = blk_mq_sched_alloc_requests(256, q->node);
>> + if (!dd->tags) {
>> + kfree(dd);
>> + kobject_put(&eq->kobj);
>> + return -ENOMEM;
>> + }
>
> Hello Jens,
>
> Please add a comment that explains where the number 256 comes from.
Pulled out of my... I'll add a comment! Really this should just be
->nr_requests soft setting, the 256 is just a random sane default that I
chose for now. I had forgotten about that, thanks.
--
Jens Axboe
