From: Colin Ian King <[email protected]> The check for a null inode is redundant since the function is a callback for exportfs, which will itself crash if dentry->d_inode or parent->d_inode is NULL. Removing the null check makes this consistent with other file systems.
Found with static analysis by CoverityScan, CID 1389472 Kudos to Jeff Mahoney for reviewing and explaining the error in my original patch (most of this explanation went into the above commit message). Signed-off-by: Colin Ian King <[email protected]> --- fs/btrfs/export.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/export.c b/fs/btrfs/export.c index 340d907..e90f781 100644 --- a/fs/btrfs/export.c +++ b/fs/btrfs/export.c @@ -235,7 +235,7 @@ static int btrfs_get_name(struct dentry *parent, char *name, int ret; u64 ino; - if (!dir || !inode) + if (!dir) return -EINVAL; if (!S_ISDIR(dir->i_mode)) -- 2.10.2
