On Fri, Dec 16, 2016 at 2:36 PM, Rafael J. Wysocki <[email protected]> wrote: > On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook <[email protected]> wrote: >> From: Emese Revfy <[email protected]> >> >> This adds the missing __printf attribute which allows compile time >> format string checking (and will be used by the coming initify gcc >> plugin). Additionally, this fixes the warnings exposed by the attribute. >> >> Signed-off-by: Emese Revfy <[email protected]> >> [kees: split scsi/acpi, merged attr and fix, new commit messages] >> Signed-off-by: Kees Cook <[email protected]> > > This modifies code that we get from an external projiect (ACPICA) and > the bugs should be fixed in there in the first place.
Who should get CCed? > Moreover, I'm not sure if adding __printf in acpiosxf.h is a good idea. Why not? This is going to be needed by the initify plugin to do correct detection of what's being passed around to functions... -Kees -- Kees Cook Nexus Security
