> -----Original Message----- > From: keesc...@google.com [mailto:keesc...@google.com] On Behalf Of Kees > Cook > Sent: Friday, December 16, 2016 3:04 PM > To: Rafael J. Wysocki <raf...@kernel.org> > Cc: Moore, Robert <robert.mo...@intel.com>; Linux Kernel Mailing List > <linux-kernel@vger.kernel.org>; Zheng, Lv <lv.zh...@intel.com>; Wysocki, > Rafael J <rafael.j.wyso...@intel.com>; Len Brown <l...@kernel.org>; ACPI > Devel Maling List <linux-a...@vger.kernel.org>; Emese Revfy > <re.em...@gmail.com>; de...@acpica.org > Subject: Re: [PATCH] acpi: Fix format string type mistakes > > On Fri, Dec 16, 2016 at 2:36 PM, Rafael J. Wysocki <raf...@kernel.org> > wrote: > > On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook <keesc...@chromium.org> > wrote: > >> From: Emese Revfy <re.em...@gmail.com> > >> > >> This adds the missing __printf attribute which allows compile time > >> format string checking (and will be used by the coming initify gcc > >> plugin). Additionally, this fixes the warnings exposed by the > attribute. > >> > >> Signed-off-by: Emese Revfy <re.em...@gmail.com> > >> [kees: split scsi/acpi, merged attr and fix, new commit messages] > >> Signed-off-by: Kees Cook <keesc...@chromium.org> > > > > This modifies code that we get from an external projiect (ACPICA) and > > the bugs should be fixed in there in the first place. > > Who should get CCed? > > > Moreover, I'm not sure if adding __printf in acpiosxf.h is a good > idea. > > Why not? This is going to be needed by the initify plugin to do correct > detection of what's being passed around to functions... >
[Moore, Robert] It's compiler-dependent. > -Kees > > -- > Kees Cook > Nexus Security
