On Tue, Dec 13, 2016 at 09:36:41AM +0100, Peter Zijlstra wrote: > futex_top_waiter() returns the top-waiter on the pi_mutex. Assinging > this to a variable 'match' totally obscures the code. >
Yes please. One wording nit... > Signed-off-by: Peter Zijlstra (Intel) <[email protected]> > --- > kernel/futex.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > --- a/kernel/futex.c > +++ b/kernel/futex.c > @@ -1317,11 +1317,11 @@ static int wake_futex_pi(u32 __user *uad > > /* > * It is possible that the next waiter (the one that brought > - * this owner to the kernel) timed out and is no longer > + * top_waiter owner to the kernel) timed out and is no longer > * waiting on the lock. > */ This breaks my parser (and did before too). Consider: /* * It is possible that the next waiter (that caused top_waiter to call * into the kernel) has since timed out and is no longer waiting on the * lock. */ Is that clearer? -- Darren Hart Intel Open Source Technology Center
