Hi Hans, On 2016년 12월 19일 09:13, Hans de Goede wrote: > axp288_handle_chrg_det_event only gets called on change interrupts > (so not that often), extcon_set_state_sync() checks itself if there are > any actual changes before notifying listeners, and gpiod_set_value is > not really expensive either. > > So we can simply always do both on each interrupt removing a bunch of > somewhat magic looking code from axp288_handle_chrg_det_event. > > Signed-off-by: Hans de Goede <hdego...@redhat.com> > --- > drivers/extcon/extcon-axp288.c | 37 ++++++++++++------------------------- > 1 file changed, 12 insertions(+), 25 deletions(-)
Looks good to me. Acked-by: Chanwoo Choi <cw00.c...@samsung.com> -- Regards, Chanwoo Choi
