On Mon, Jan 09, 2017 at 05:47:38PM +0100, jeroen.de_wachter....@nokia.com wrote: > From: Jeroen De Wachter <jeroen.de_wachter....@nokia.com> > > Signed-off-by: Jeroen De Wachter <jeroen.de_wachter....@nokia.com> > --- > drivers/hwmon/tmp401.c | 66 > +++++++++++++++++++++++++------------------------- > 1 file changed, 33 insertions(+), 33 deletions(-) > > diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c > index 88b17e4..853056d 100644 > --- a/drivers/hwmon/tmp401.c > +++ b/drivers/hwmon/tmp401.c > @@ -498,40 +498,40 @@ static ssize_t set_update_interval(struct device *dev, > return count; > } > > -static SENSOR_DEVICE_ATTR_2(temp1_input, S_IRUGO, show_temp, NULL, 0, 0); > -static SENSOR_DEVICE_ATTR_2(temp1_min, S_IWUSR | S_IRUGO, show_temp, > +static SENSOR_DEVICE_ATTR_2(temp1_input, 0444, show_temp, NULL, 0, 0); > +static SENSOR_DEVICE_ATTR_2(temp1_min, 0644, show_temp,
I hate this change :-(. Please don't bother. I have a coccinelle driven series in the works which makes those changes automatically for all drivers (and, along the line, simplifies the SENSOR_DEVICE_ATTR[_2] macros). Thanks, Guenter