Em Sun, Jan 08, 2017 at 07:57:53PM +0100, Jiri Olsa escreveu:
> On Tue, Jan 03, 2017 at 07:08:23AM -0800, Andi Kleen wrote:
>
> SNIP
>
> > - goto error;
> > -
> > - if (scale[sret - 1] == '\n')
> > - scale[sret - 1] = '\0';
> > - else
> > - scale[sret] = '\0';
> > + int ret = 0;
> >
> > /*
> > * save current locale
> > @@ -133,8 +111,8 @@ static int perf_pmu__parse_scale(struct perf_pmu_alias
> > *alias, char *dir, char *
> > */
> > lc = strdup(lc);
> > if (!lc) {
> > - ret = -ENOMEM;
> > - goto error;
> > + ret = -1;
> > + goto out;
>
> not sure why you changed the -ENOMEM to -1 ;-) but it's ok anyway
These unrelated things are just that, noise, I'll ditch it to reduce
patch size while not introducing any functional change.
> Acked-by: Jiri Olsa <[email protected]>
Will keep your ack tho :-)
- Arnaldo
> thanks,
> jirka
