On Dec 26, 2016, at 08:43, Guillermo O. Freschi <ked...@gmail.com> wrote:
>
> Was `unsigned int`, but `enum`s are signed.
Interesting that GCC didn't complain that the itree_overlap_cb() function
signature didn't match the argument prototype for interval_search():
typedef enum interval_iter (*interval_callback_t)(struct interval_node *node,
void *args);
In the end it is a somewhat cosmetic fix, because the only enum values
(1, 2) were unsigned, but good to be consistent. Thanks for the fix.
> Signed-off-by: Guillermo O. Freschi <ked...@gmail.com>
Reviewed-by: Andreas Dilger <andreas.dil...@intel.com>
> ---
> drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> index a4a291acb659..f4cbc89b4f24 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> @@ -1148,7 +1148,7 @@ static int lock_matches(struct ldlm_lock *lock, struct
> lock_match_data *data)
> return INTERVAL_ITER_STOP;
> }
>
> -static unsigned int itree_overlap_cb(struct interval_node *in, void *args)
> +static enum interval_iter itree_overlap_cb(struct interval_node *in, void
> *args)
> {
> struct ldlm_interval *node = to_ldlm_interval(in);
> struct lock_match_data *data = args;
> --
> 2.11.0
>
> _______________________________________________
> lustre-devel mailing list
> lustre-de...@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
