On Sat, 2017-01-14 at 09:26 +0100, Ingo Molnar wrote:
> * Ingo Molnar <[email protected]> wrote:
[]
> In particular the random line breaks, apparently to pacify checkpatch, were
> horribly widespread. I just made the lines longer - that's still more readable
> than the multi-line horror that was there before.
[]
> arch/x86/kernel/apic/x2apic_uv_x.c |  500 
>++++++++++++++++++-------------------
[]
> -     pr_info("UV: OEM IDs %s/%s, System/HUB Types %d/%d, uv_apic %d\n",
> -             oem_id, oem_table_id, uv_system_type,
> -             uv_min_hub_revision_id, uv_apic);
> +     pr_info("UV: OEM IDs %s/%s, System/HUB Types %d/%d, uv_apic %d\n", 
> oem_id, oem_table_id, uv_system_type, uv_min_hub_revision_id, uv_apic);

140+ chars on a single line.

Is this really better or easier to read?

Long lines make it harder to humans to verify
format and arguments used in printf type calls.

Reply via email to