On Mon, Jan 23, 2017 at 6:08 PM, Dan O'Donovan <d...@emutex.com> wrote: > From: Crestez Dan Leonard <leonard.cres...@intel.com> > > When using devicetree i2c_board_info.type is set to the compatible > string with the vendor prefix removed. For I2C devices described via > ACPI the i2c_board_info.type string is set to the ACPI device name. When > using ACPI and DT ids this string ends up something like "PRP0001:00". > > If the of_compatible property is present try to use that instead. This > makes it easier to instantiate i2c drivers through ACPI with DT ids.
> - strlcpy(info->type, dev_name(&adev->dev), sizeof(info->type)); > + /* > + * Populate modalias from compatible property if available, > + * otherwise use native ACPI information > + */ > + if ((!adev->data.of_compatible) || > + acpi_of_modalias(adev, info->type, sizeof(info->type))) Redundant parens in lvalue. After removing them is it possible to use one line for it? > + strlcpy(info->type, dev_name(&adev->dev), sizeof(info->type)); -- With Best Regards, Andy Shevchenko
