On Mon, Jan 23, 2017 at 6:08 PM, Dan O'Donovan <d...@emutex.com> wrote: > From: Crestez Dan Leonard <leonard.cres...@intel.com> > > When using devicetree spi_device.modalias is set to the compatible > string with the vendor prefix removed. For SPI devices described via > ACPI the spi_device.modalias string is initialized by acpi_device_hid. > When using ACPI and DT ids this string ends up something like "PRP0001". > > Change acpi_register_spi_device to use the of_compatible property if > present. This makes it easier to instantiate spi drivers through ACPI > with DT ids.
> + /* > + * Populate modalias from compatible property if available, > + * otherwise use native ACPI information > + */ > + if ((!adev->data.of_compatible) || > + acpi_of_modalias(adev, spi->modalias, sizeof(spi->modalias))) Same comment as in patch 2. > + strlcpy(spi->modalias, acpi_device_hid(adev), > + sizeof(spi->modalias)); Could this be one line? -- With Best Regards, Andy Shevchenko
