* Kirill A. Shutemov <[email protected]> [2017-01-24 19:28:21]:
> For consistency, it worth converting all page_check_address() to > page_check_walk(), so we could drop the former. > > Signed-off-by: Kirill A. Shutemov <[email protected]> > --- > kernel/events/uprobes.c | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index 1e65c79e52a6..6dbaa93b22fa 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -153,14 +153,19 @@ static int __replace_page(struct vm_area_struct *vma, > unsigned long addr, > struct page *old_page, struct page *new_page) > { > struct mm_struct *mm = vma->vm_mm; I thought the subject is a bit misleading, it looks as if we are replacing __replace_page. Can it be changed to "Convert __replace_page() to use page_check_walk()" ? Otherwise looks good to me. Reviewed-by: Srikar Dronamraju <[email protected]>
