On Fri, 2017-01-27 at 09:15 +0100, Greg Kroah-Hartman wrote: > On Thu, Jan 26, 2017 at 05:16:26PM +0200, Tomas Winkler wrote: > > Use devm_ and pcim_ functions to make error handling > > simpler and code smaller and tidier. > > > > Based on original patch by > > mei: me: use managed functions pcim_* and devm_* > > https://lkml.org/lkml/2016/2/1/339 > > > > Signed-off-by: Tomas Winkler <[email protected]> > > Signed-off-by: Alexander Usyskin <[email protected]> > > Signed-off-by: Andy Shevchenko <[email protected]> > > --- > > V2: Thanks Andy for review, integratd changes: > > 1. Rename devm_mei_me_init back to mei_me_dev_init > > they don't really belong to devm_ namespace. > > 2. Revert pcim irq reservation change. > > 3. Drop setting driver data to NULL on exit. > > 4. Use directly mmio pointer received from pcim_iomap_table > > V3: Remove pci_disable_msi, it is also handled by the system. > > Andy, any objection to this version?
Nope, this looks exactly how I would put it! Thanks! -- Andy Shevchenko <[email protected]> Intel Finland Oy
