On Fri 03-02-17 15:42:55, Hillf Danton wrote:
>
> On February 03, 2017 3:20 AM Johannes Weiner wrote:
> > @@ -1063,7 +1063,7 @@ static unsigned long shrink_page_list(struct
> > list_head *page_list,
> > PageReclaim(page) &&
> > test_bit(PGDAT_WRITEBACK, &pgdat->flags)) {
> > nr_immediate++;
> > - goto keep_locked;
> > + goto activate_locked;
>
> Out of topic but relevant IMHO, I can't find where it is cleared by grepping:
>
> $ grep -nr PGDAT_WRITEBACK linux-4.9/mm
> linux-4.9/mm/vmscan.c:1019: test_bit(PGDAT_WRITEBACK, &pgdat->flags)) {
> linux-4.9/mm/vmscan.c:1777: set_bit(PGDAT_WRITEBACK, &pgdat->flags);
I would just get rid of this flag.
--
Michal Hocko
SUSE Labs
