Re: [PATCH v3 01/14] mm: thp: make __split_huge_pmd_locked visible.

[Matthew Wilcox]

On Sun, Feb 05, 2017 at 11:12:39AM -0500, Zi Yan wrote:
> +++ b/include/linux/huge_mm.h
> @@ -120,6 +120,8 @@ static inline int split_huge_page(struct page *page)
>  }
>  void deferred_split_huge_page(struct page *page);
>  
> +void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
> +             unsigned long haddr, bool freeze);

Could you change that from 'haddr' to 'address' so callers who only
read the header instead of the implementation aren't expecting to align
it themselves?

> +void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
> +             unsigned long address, bool freeze)
>  {
>       struct mm_struct *mm = vma->vm_mm;
>       struct page *page;