Hi Markus,
On Wed, Jan 18, 2017 at 5:47 PM, SF Markus Elfring
<[email protected]> wrote:
> From: Markus Elfring <[email protected]>
> Date: Wed, 18 Jan 2017 16:30:36 +0100
>
> Return directly after a call of the function "capable" failed
> at the beginning.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> arch/m68k/kernel/sys_m68k.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/m68k/kernel/sys_m68k.c b/arch/m68k/kernel/sys_m68k.c
> index 9aa01adb407f..62bfeb3716a7 100644
> --- a/arch/m68k/kernel/sys_m68k.c
> +++ b/arch/m68k/kernel/sys_m68k.c
> @@ -384,9 +384,8 @@ sys_cacheflush (unsigned long addr, int scope, int cache,
> unsigned long len)
>
> if (scope == FLUSH_SCOPE_ALL) {
> /* Only the superuser may explicitly flush the whole cache. */
> - ret = -EPERM;
> if (!capable(CAP_SYS_ADMIN))
> - goto out;
> + return -EPERM;
Given there is another "goto out" before this, I won't take this patch as-is.
> } else {
> struct vm_area_struct *vma;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
