On Fri, 10 Feb 2017 19:29:44 +0200 "Michael S. Tsirkin" <[email protected]> wrote:
> These are supplied by the linker and only used by jump_label.c. > This trivial patch moves them out of jump_label.h. > > Cc: Jason Baron <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Cc: Steven Rostedt <[email protected]> > Cc: Borislav Petkov <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: Linus Torvalds <[email protected]> > Cc: Thomas Gleixner <[email protected]> > Cc: Mel Gorman <[email protected]> > Cc: Ingo Molnar <[email protected]> > Signed-off-by: Michael S. Tsirkin <[email protected]> > --- > include/linux/jump_label.h | 3 --- > kernel/jump_label.c | 4 ++++ > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h > index 48ed83f..21701da 100644 > --- a/include/linux/jump_label.h > +++ b/include/linux/jump_label.h > @@ -132,9 +132,6 @@ static __always_inline bool static_key_true(struct > static_key *key) > return !arch_static_branch(key, true); > } > > -extern const struct jump_entry __start___jump_table[]; > -extern const struct jump_entry __stop___jump_table[]; > - > extern void jump_label_init(void); > extern void jump_label_lock(void); > extern void jump_label_unlock(void); > diff --git a/kernel/jump_label.c b/kernel/jump_label.c > index a9b8cf5..6eaa84c 100644 > --- a/kernel/jump_label.c > +++ b/kernel/jump_label.c > @@ -18,6 +18,10 @@ > > #ifdef HAVE_JUMP_LABEL > > +/* Supplied by a linker script */ This is common practice and obvious to anyone that does a git grep. I don't really think the comment is necessary. But the change itself is fine. Reviewed-by: Steven Rostedt (VMware) <[email protected]> -- Steve > +extern struct jump_entry __start___jump_table[]; > +extern struct jump_entry __stop___jump_table[]; > + > /* mutex to protect coming/going of the the jump_label table */ > static DEFINE_MUTEX(jump_label_mutex); >
