Hello! On 3/3/2017 2:36 AM, John Stultz wrote:
I had seen some odd behavior with HiKey's usb-gadget interface that I finally seemed to have chased down. Basically every other time I pluged in the OTG port, the gadget interface would
Plugged. Perhaps could be fixed while applying...
properly initialize. The other times, I'd get a big WARN_ON in dwc2_hsotg_init_fifo() about the fifo_map not being clear. Ends up if we don't disconnect the gadget state, the fifo-map doesn't get cleared properly, which causes WARN_ON messages and also results in the device not properly being setup as a gadget every other time the OTG port is connected. So this patch adds a call to dwc2_hsotg_disconnect() in the reset path so the state is properly cleared. With it, the gadget interface initializes properly on every plug in. Cc: Wei Xu <xuw...@hisilicon.com> Cc: Guodong Xu <guodong...@linaro.org> Cc: Amit Pundir <amit.pun...@linaro.org> Cc: Rob Herring <robh...@kernel.org> Cc: John Youn <johny...@synopsys.com> Cc: Douglas Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-...@vger.kernel.org Acked-by: John Youn <johny...@synopsys.com> Signed-off-by: John Stultz <john.stu...@linaro.org>
[...] MBR, Sergei