Commit-ID:  001916b94a04809a94abb07daba6f9ace01906ba
Gitweb:     http://git.kernel.org/tip/001916b94a04809a94abb07daba6f9ace01906ba
Author:     Jiri Olsa <jo...@kernel.org>
AuthorDate: Sun, 5 Mar 2017 17:40:11 +0100
Committer:  Arnaldo Carvalho de Melo <a...@redhat.com>
CommitDate: Mon, 6 Mar 2017 12:39:30 -0300

perf bench numa: Add more comment for -c option

Adding more commentary for -c/--show_convergence option, to explain how
the convergence is defined.

Before:
    -c, --show_convergence
                          show convergence details

Now:
    -c, --show_convergence
                          convergence is reached when each process \
        (all its threads) is running on a single NUMA node.

Suggested--by: Jiri Hladky <jhla...@redhat.com>
Signed-off-by: Jiri Olsa <jo...@kernel.org>
Cc: David Ahern <dsah...@gmail.com>
Cc: Jiri Hladky <jhla...@redhat.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Link: 
http://lkml.kernel.org/r/1488732011-27384-1-git-send-email-jo...@kernel.org
[ Rephrased a bit based on a IRC conversation with Jiri ]
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/bench/numa.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c
index 3083fc3..6bd0581 100644
--- a/tools/perf/bench/numa.c
+++ b/tools/perf/bench/numa.c
@@ -187,7 +187,8 @@ static const struct option options[] = {
        OPT_INCR   ('d', "show_details" , &p0.show_details,     "Show details"),
        OPT_INCR   ('a', "all"          , &p0.run_all,          "Run all tests 
in the suite"),
        OPT_INTEGER('H', "thp"          , &p0.thp,              
"MADV_NOHUGEPAGE < 0 < MADV_HUGEPAGE"),
-       OPT_BOOLEAN('c', "show_convergence", &p0.show_convergence, "show 
convergence details"),
+       OPT_BOOLEAN('c', "show_convergence", &p0.show_convergence, "show 
convergence details, "
+                   "convergence is reached when each process (all its threads) 
is running on a single NUMA node."),
        OPT_BOOLEAN('m', "measure_convergence", &p0.measure_convergence, 
"measure convergence latency"),
        OPT_BOOLEAN('q', "quiet"        , &p0.show_quiet,       "quiet mode"),
        OPT_BOOLEAN('S', "serialize-startup", &p0.serialize_startup,"serialize 
thread startup"),

Reply via email to