On Sun, 5 Mar 2017 08:35:33 -0500, Jeff Layton <[email protected]> wrote: > In a later patch, we're going to want to make the fsync codepath not do > a TestClearPageError call as that can override the error set in the > address space. To do that though, we need to ensure that filesystems > that are relying on the PG_error bit for reporting writeback errors > also set an error in the address space. > > The only place I've found that looks potentially problematic is this > spot in nilfs2. Ensure that it sets an error in the mapping in addition > to setting PageError. > > Signed-off-by: Jeff Layton <[email protected]>
Acked-by: Ryusuke Konishi <[email protected]> Agreed that nilfs2 needs this if the successive patch is applied. Thanks, Ryusuke Konishi > --- > fs/nilfs2/segment.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c > index bedcae2c28e6..c1041b07060e 100644 > --- a/fs/nilfs2/segment.c > +++ b/fs/nilfs2/segment.c > @@ -1743,6 +1743,7 @@ static void nilfs_end_page_io(struct page *page, int > err) > } else { > __set_page_dirty_nobuffers(page); > SetPageError(page); > + mapping_set_error(page_mapping(page), err); > } > > end_page_writeback(page); > -- > 2.9.3 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to [email protected]. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"[email protected]";> [email protected] </a>
