On Tue, Mar 7, 2017 at 10:28 AM, Josh Poimboeuf <jpoim...@redhat.com> wrote: > > Also, the gcc documentation says -maccumulate-outgoing-args is > "generally beneficial for performance and size."
Hmm. I wonder how true that is. I'm pretty sure it generates bigger code, although it's probably less noticeable in the kernel (as opposed to the traditional x86 "push everything" model) due to having the three register arguments. And the "it's faster" is almost certainly garbage. It's true on P4 and some older AMD cores that couldn't do push/pops quickly. > Not to mention the fact that -maccumulate-outgoing-args seems to already > be enabled in most cases anyway. Yeah, that's the main argument for this patch, I think - just remove the (unusual) special case. Linus