On Wed, 8 Mar 2017, Josh Poimboeuf wrote: > On Wed, Mar 08, 2017 at 10:16:00AM +0100, Jiri Kosina wrote: > > From: Jiri Kosina <jkos...@suse.cz> > > > > klp_mutex is shared between core.c and transition.c, and as such would > > rather be properly located in livepatch.h so that we don't have to play > > 'extern' games from .c sources. > > > > This also silences sparse warning (wrongly) suggesting that klp_mutex > > should be defined static. > > include/linux/livepatch.h is the public interface, whereas klp_mutex is > a private implementation detail. I think it would be a better fit in > kernel/livepatch/core.h (though that file doesn't yet exist).
Yes, that would be ideal and I thought about it too. linux/livepatch.h is suboptimal fallback, because I did not find it necessary to have another header file just because of klp_mutex. But I'll be all for it, if everyone is in favour. Miroslav
