On Wed, 15 Mar 2017 12:19:48 +0000 Lee Jones <[email protected]> wrote:
> On Tue, 14 Mar 2017, Boris Brezillon wrote: > > > On Tue, 14 Mar 2017 17:00:03 +0000 > > Lee Jones <[email protected]> wrote: > > > > > On Mon, 20 Feb 2017, Boris Brezillon wrote: > > > > > > > These new helpers + macro definitions are meant to replace the old ones > > > > which are unpractical to use. > > > > > > > > Note that the macros and function prefixes have been intentionally > > > > changed to ATMEL_[H]SMC_XX and atmel_[h]smc_ to reflect the fact that > > > > this IP is also embedded in avr32 SoCs (and not only in at91 ones). > > > > > > I'm going to NACK this patch. > > > > > > I don't see any reason why all those functions have to be inline and > > > shoved into a header file. > > > > Because those are simple conversion helpers, and I thought a > > dedicated C file was not required, but I can move them into a C file > > and export these functions using EXPORT_SYMBOL_GPL() if you prefer. > > > > Would that work for you? > > I think that would be better TBH. Those functions aren't all that > simple. There is certainly too much meat on the bones for me to be > happy for them to be shoved into a header file. > I'm fine with that. Are you okay if I put this code in drivers/mfd/atmel-smc.c?
