On Thu, Mar 23, 2017 at 11:54 PM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Thu, Mar 23, 2017 at 02:47:39PM -0700, Grant Grundler wrote: >> On Tue, Mar 14, 2017 at 12:56 AM, Clemens Ladisch <clem...@ladisch.de> wrote: >> > Matthias Kaehlcke wrote: >> >> The value passed by the two callers of the function is unsigned anyway. >> > >> > Indeed; and those are just simple wrappers. >> > >> >> Making the parameter unsigned fixes the following warning when building >> >> with clang: >> >> >> >> drivers/char/hpet.c:588:7: error: overflow converting case value to >> >> switch condition type (2149083139 to 18446744071563667459) >> >> [-Werror,-Wswitch] >> >> case HPET_INFO: >> >> ^ >> >> include/uapi/linux/hpet.h:18:19: note: expanded from macro 'HPET_INFO' >> >> ^ >> >> include/uapi/asm-generic/ioctl.h:77:28: note: expanded from macro '_IOR' >> >> ^ >> >> include/uapi/asm-generic/ioctl.h:66:2: note: expanded from macro '_IOC' >> >> (((dir) << _IOC_DIRSHIFT) | \ >> >> >> >> Signed-off-by: Matthias Kaehlcke <m...@chromium.org> >> > >> > Acked-by: Clemens Ladisch <clem...@ladisch.de> >> >> Any other feedback on this patch? >> Or has this already been added to someone's "for-linus" branch? >> >> just looking for update on patch status. > > This is already in my -next branch, to go into 4.12-rc1. Should it get > into 4.11-final instead?
I would say "no" since 4.12-rc1 is good enough for me. Thanks! :) cheers, grant > > thanks, > > greg k-h
