Hi Gustavo, On Mon, Mar 27, 2017 at 01:37:29AM -0500, Gustavo A. R. Silva wrote: > Fix the following sparse warning: > symbol 'spk_serial_out' was not declared. Should it be static? > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> > --- > drivers/staging/speakup/serialio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/serialio.c > b/drivers/staging/speakup/serialio.c > index 5e31aca..3fab1c3 100644 > --- a/drivers/staging/speakup/serialio.c > +++ b/drivers/staging/speakup/serialio.c > @@ -243,7 +243,7 @@ unsigned char spk_serial_in_nowait(void) > } > EXPORT_SYMBOL_GPL(spk_serial_in_nowait); > > -int spk_serial_out(struct spk_synth *in_synth, const char ch) > +static int spk_serial_out(struct spk_synth *in_synth, const char ch) > { > if (in_synth->alive && spk_wait_for_xmitr(in_synth)) { > outb_p(ch, speakup_info.port_tts); > -- > 2.5.0 >
Thanks for this :) Could you also move the function higher in the same file - above line 139 where all static functions are defined? Okash