On Sun, Mar 26, 2017 at 12:13 AM, Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > On Fri 24 Mar 08:06 PDT 2017, Rob Herring wrote: > >> On Fri, Mar 17, 2017 at 09:15:22PM -0700, Bjorn Andersson wrote: > [..] >> > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt >> > b/Documentation/devicetree/bindings/firmware/qcom,scm.txt >> > index 20f26fbce875..8467a181f22c 100644 >> > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt >> > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt >> > @@ -18,6 +18,7 @@ Required properties: >> > * Core, iface, and bus clocks required for "qcom,scm" >> > - clock-names: Must contain "core" for the core clock, "iface" for the >> > interface >> > clock and "bus" for the bus clock per the requirements of the >> > compatible. >> > +- qcom,dload-mode-addr: Specifies the address for the download mode magic >> > (optional) >> >> Size? 1 cell, 2 cell(, red cell, blue cell) or follows #addr-cells? >> > > I believe this implementation only applies to the 64-bit systems, but > it's probably better to make it follow (or at least claim that it > follows) #address-cells.
Saying it is fixed 2 cells is fine and slightly easier to parse. Just be explicit. Rob
