On Fri, 2017-03-31 at 20:18 -0700, Chewie Lin wrote:
> These are good points, but any feedback on the dev_warn() call itself?
> I was trying to fix the checkpatch warning on my first try.

Using "%s" with a long string is generally inefficient.

Compare the compiled object size of
        printf("%s is %d\n", "Long string", 1);
to
        printf("Long string is %d\n", 1); 

Reply via email to